felipecrv commented on code in PR #40774:
URL: https://github.com/apache/arrow/pull/40774#discussion_r1538490823
##########
cpp/src/arrow/io/file_test.cc:
##########
@@ -461,6 +461,11 @@ class MyMemoryPool : public MemoryPool {
return Status::OK();
}
+ Status ReallocateNoCopy(int64_t old_size, int64_t new_size, int64_t
alignment,
+ uint8_t** ptr) override {
+ return Reallocate(old_size, new_size, alignment, ptr);
Review Comment:
My comment above also implies that the implementation should be `return
Status::NotImplemented()` so that caller immediately fallback to the
`Reallocate()` with a size that is not necessarily the size that was passed to
`TryResize`. The size passed to `TryResize` is conservative whereas the size
passed to `Reallocate` is often more generous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
