felipecrv commented on code in PR #40774:
URL: https://github.com/apache/arrow/pull/40774#discussion_r1538495332
##########
cpp/src/arrow/io/file_test.cc:
##########
@@ -461,6 +461,11 @@ class MyMemoryPool : public MemoryPool {
return Status::OK();
}
+ Status ReallocateNoCopy(int64_t old_size, int64_t new_size, int64_t
alignment,
Review Comment:
You could also change the return type to `[[nodiscard]] bool`. I don't think
we really need the richness of `Status` to express what happened. `false` for
exceptional/validation error and also impossibility of the resize-in-place will
cause the caller to call a different allocation function that can then be more
detailed in the `Status` it returns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
