ZhangHuiGui commented on code in PR #40484: URL: https://github.com/apache/arrow/pull/40484#discussion_r1539359922
########## cpp/src/arrow/compute/key_hash.cc: ########## @@ -383,19 +383,30 @@ void Hashing32::HashMultiColumn(const std::vector<KeyColumnArray>& cols, uint32_t num_rows = static_cast<uint32_t>(cols[0].length()); constexpr uint32_t max_batch_size = util::MiniBatch::kMiniBatchLength; + const uint32_t alloc_batch_size = std::min(num_rows, max_batch_size); + const int64_t estimate_alloc_size = EstimateBatchStackSize<uint32_t>(alloc_batch_size); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
