ZhangHuiGui commented on code in PR #40484:
URL: https://github.com/apache/arrow/pull/40484#discussion_r1539362497
##########
cpp/src/arrow/compute/key_hash.h:
##########
@@ -219,5 +219,24 @@ class ARROW_EXPORT Hashing64 {
const uint8_t* keys, uint64_t* hashes);
};
+template <typename T = uint32_t>
+static int64_t EstimateBatchStackSize(int32_t batch_size) {
Review Comment:
Actually, i want to unify the logic in Hashing32 and Hashing64. But seems
unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
