llama90 commented on code in PR #40761: URL: https://github.com/apache/arrow/pull/40761#discussion_r1542343616
########## python/pyarrow/types.py: ########## @@ -64,17 +82,17 @@ def is_boolean(t): @doc(is_null, datatype="any integer") def is_integer(t): - return t.id in _INTEGER_TYPES + return is_integer_type(t) Review Comment: I wrote the wrapper for the C++ function to use the `is_integer` function, thinking someone might use it while working with pyarrow for compatibility. Should we not consider this aspect? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
