llama90 commented on PR #40761:
URL: https://github.com/apache/arrow/pull/40761#issuecomment-2024781808
I've updated the docstrings based on the review and made adjustments to
ensure that existing functions work using the functions in `type_traits.h` that
are already available.
I understand that pyarrow has a wide user base, and to avoid breaking
compatibility, I've made sure that functions in the form of `is_${type}` can
still operate as intended. (If I'm mistaken, please let me know.)
Additionally, I plan to create a new issue to address types such as `NA`,
`BINARY_VIEW`, `STRING_VIEW`, `FIXED_SIZE_LIST`, `STRUCT`, and
`RUN_END_ENCODED`, which have the following considerations:
- `NA`, `BINARY_VIEW`, `STRING_VIEW` require C++ implementation in
`type_traits.h`.
- While there are functions to check `FIXED_SIZE_LIST`, `STRUCT`,
`RUN_END_ENCODED` types in `type_traits.h`, they might not be directly usable.
This requires further consideration, and I intend to proceed with a new
issue for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
