paleolimbot opened a new pull request, #40873:
URL: https://github.com/apache/arrow/pull/40873

   
   ### Rationale for this change
   
   Before fixing nanoarrow's testing JSON reader to align with other 
implementations and properly zero out the last few bits, integration tests 
failed because C#'s `CompareValidityBuffer()` was comparing the bytes of the 
validity buffer (including undefined final bits that are maybe not identical 
due to uninitialized memory or because the arrays are slices).
   
   ### What changes are included in this PR?
   
   `CompareValidityBuffer()` now compares the memory for all except the last 
byte and compares the last byte bitwise.
   
   ### Are these changes tested?
   
   They should be but I am not sure exactly where to add the test!
   
   ### Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to