paleolimbot commented on code in PR #40873:
URL: https://github.com/apache/arrow/pull/40873#discussion_r1543332332
##########
csharp/test/Apache.Arrow.Tests/ArrowReaderVerifier.cs:
##########
@@ -432,12 +432,25 @@ private void CompareValidityBuffer(int nullCount, int
arrayLength, ArrowBuffer e
{
Assert.True(expectedValidityBuffer.Span.SequenceEqual(actualValidityBuffer.Span));
}
- else if (nullCount != 0)
+ else if (nullCount != 0 && arrayLength > 0)
{
int validityBitmapByteCount =
BitUtility.ByteCount(arrayLength);
+ ReadOnlySpan<byte> expectedSpan =
expectedValidityBuffer.Span.Slice(0, validityBitmapByteCount);
Review Comment:
😬 (this is the first C# I've ever attempted!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
