alamb commented on PR #9780: URL: https://github.com/apache/arrow-datafusion/pull/9780#issuecomment-2026481192
Update here is that I think this PR now has the basic code to do in-place updates of TreeNodes in general and `LogicalPlan`s in particular 🎉 TODOs: - [ ] Run performance benchmarks to show this helps - [ ] Complete edge case implementations (DDL, user defined nodes), polish PR description Follow ons: - [ ] File ticket for supporting rewriting `Expr`s in place (implement `TreeNodeMutator` -- specifically ExprRewriter should be a big win) - [ ] File ticket for: Better OptimizerRule API to support rewriting in place - [ ] File ticket for: API to support rewrites of UserDefinedLogicalPlan - [ ] File ticket for: change additional uses of `TreeNodeRewriter` to `TreeNodeMutator` - [ ] File ticket for: change additional uses of TreeNodeRewriter to TreeNodeMutator - [ ] File ticket for an example of how to use the "in place tree write" API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
