alamb commented on code in PR #9780: URL: https://github.com/apache/arrow-datafusion/pull/9780#discussion_r1544595518
########## datafusion/sqllogictest/test_files/subquery.slt: ########## @@ -531,13 +531,13 @@ query TT explain SELECT t0_id, t0_name FROM t0 WHERE EXISTS (SELECT 1 FROM t1 INNER JOIN t2 ON(t1.t1_id = t2.t2_id and t1.t1_name = t0.t0_name)) ---- logical_plan -Filter: EXISTS (<subquery>) ---Subquery: -----Projection: Int64(1) -------Inner Join: Filter: t1.t1_id = t2.t2_id AND t1.t1_name = outer_ref(t0.t0_name) ---------TableScan: t1 ---------TableScan: t2 +LeftSemi Join: t0.t0_name = __correlated_sq_2.t1_name Review Comment: this actually seems like an improvement to me -- as the plans are now properly lowered ########## datafusion/sqllogictest/test_files/subquery.slt: ########## @@ -531,13 +531,13 @@ query TT explain SELECT t0_id, t0_name FROM t0 WHERE EXISTS (SELECT 1 FROM t1 INNER JOIN t2 ON(t1.t1_id = t2.t2_id and t1.t1_name = t0.t0_name)) ---- logical_plan -Filter: EXISTS (<subquery>) ---Subquery: -----Projection: Int64(1) -------Inner Join: Filter: t1.t1_id = t2.t2_id AND t1.t1_name = outer_ref(t0.t0_name) ---------TableScan: t1 ---------TableScan: t2 +LeftSemi Join: t0.t0_name = __correlated_sq_2.t1_name Review Comment: this actually seems like an improvement to me -- as the plans are now properly visited by the rewriter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
