cgbur commented on code in PR #5557: URL: https://github.com/apache/arrow-rs/pull/5557#discussion_r1544871954
########## parquet/src/arrow/buffer/view_buffer.rs: ########## Review Comment: Why has this type been added? The implementation of a `Vev<Option<Vec<u8>>` is quite memory inefficient and has been avoided in the past. Why not use other efficient types such as the [binary arrays](https://docs.rs/arrow/latest/arrow/array/type.BinaryArray.html) and their builders that already exist in this crate? I see later that you then convert into the more efficient types by iterating over this and constructing the binary type. Can we avoid this inefficient middleman altogether? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
