tustvold commented on code in PR #5557: URL: https://github.com/apache/arrow-rs/pull/5557#discussion_r1544924028
########## parquet/src/arrow/buffer/view_buffer.rs: ########## Review Comment: Not had time to properly review this PR, will take a proper look after Easter, but I would not expect us to be copying any string data at all. The views should be into the parquet page data directly, we shouldn't be doing any copying of string payloads at all (except for possibly the prefix string case). A Buffer can be created directly from the Bytes used for parquet pages and so in many cases a copy can be avoided -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
