alamb commented on code in PR #9885:
URL: https://github.com/apache/arrow-datafusion/pull/9885#discussion_r1545628682
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -1064,6 +1076,7 @@ mod tests {
assert!(metrics.elapsed_compute().unwrap() > 0);
assert!(metrics.spill_count().unwrap() > 0);
assert!(metrics.spilled_bytes().unwrap() > 0);
+ assert!(metrics.spilled_rows().unwrap() > 0);
Review Comment:
I wonder if we can actually check the spilled row count here 🤔 It should be
deterministic right?
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -654,7 +666,7 @@ async fn spill_sorted_batches(
batches: Vec<RecordBatch>,
path: &Path,
schema: SchemaRef,
-) -> Result<()> {
+) -> Result<u64> {
Review Comment:
Can we possibly add a brief comment describing that the returned value is
the row counts that is spilled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
