erenavsarogullari commented on code in PR #9885:
URL: https://github.com/apache/arrow-datafusion/pull/9885#discussion_r1547116039
##########
datafusion/physical-plan/src/sorts/sort.rs:
##########
@@ -697,7 +709,7 @@ fn write_sorted(
writer.num_rows,
human_readable_size(writer.num_bytes as usize),
);
- Ok(())
+ Ok(writer.num_rows)
Review Comment:
Thanks for the review. This is good point. I think it is also valid for
`num_batches` and `num_bytes` and this requires redundant casting on
`IPCWriter.write()` and `ExternalSorter.spill()`. I plan to submit separate PR
for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
