yyy1000 commented on code in PR #9897:
URL: https://github.com/apache/arrow-datafusion/pull/9897#discussion_r1546642518
##########
datafusion/sql/src/expr/mod.rs:
##########
@@ -603,6 +604,25 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
if !fields.is_empty() {
return not_impl_err!("Struct fields are not supported yet");
}
+
+ if values
+ .iter()
+ .any(|value| matches!(value, SQLExpr::Named { .. }))
+ {
+ self.create_named_struct(values, input_schema, planner_context)
Review Comment:
I think the values in `create_named_struct` will be `SQLExpr::Named` in this
PR, so maybe we can also make a change here?
https://github.com/apache/arrow-datafusion/blob/d8d521ac8b90002fa0ba1f91456051a9775ae193/datafusion/sql/src/expr/mod.rs#L610-L631
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
