alamb commented on PR #9897: URL: https://github.com/apache/arrow-datafusion/pull/9897#issuecomment-2032762771
> thanks @alamb 1 improvement I can see here is we over iterating through values. I mean 1 iteration is do identify named/not_named and when creating struct/named_struct its another one. prob it can be optimized I agree it does two iterations over the value. I think the current approach basically requires two iterations because if we are doing `named_struct` we need to add names for each column that don't have a name. So in other words, `struct(1, 2, 3 as other_col)` needs to become `struct(1 as c1, 2 as c2, 3 as other_col)` but we don't know until we see `3 as other_col` that we need to add in `c1` and `c2`) 🤔 I would like to spend my optimization budget on bigger things initially if that is ok (specifically https://github.com/apache/arrow-datafusion/issues/9637) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
