seddonm1 commented on pull request #9243: URL: https://github.com/apache/arrow/pull/9243#issuecomment-778716368
@alamb Thanks for your extreme attention to detail and yes it is absolutely IMPLEMENT ALL THE FUNCTIONS 😆 I have addressed and resolved most of the comments you have made. The remaining unresolved comments do require further discussion. I am happy to do the split based on your suggestions and I'm ok to raise the tickets: - `bit_length` kernels + `length` comments - `Signature::OneOf` - Length functions (BitLength, etc) - Ascii/unicode functions - Regex functions - Pad/trim functions Obviously this is a lot of work but this should allow us to split up the reviews more fairly. I will start the PR-mageddon. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
