seddonm1 commented on pull request #9243: URL: https://github.com/apache/arrow/pull/9243#issuecomment-779486975
@alamb @jorgecarleitao I have applied the new API (mostly using the `make_scalar_function` helper) to all the functions. My final question before doing the separate PRs is regarding the Postgres license (https://www.postgresql.org/about/licence/). While doing this PR and aiming for Postgres compatibility I have looked at the Postgres source code, used their documentation examples as test cases and used their documentation descriptions (as they are very clear and well written). I think this license is required as a byproduct of adopting the Postgres SQL standard and ensuring compatability. E.g. Postgres Documentation (https://www.postgresql.org/docs/13/functions-string.html): ``` Converts the string to all upper case, according to the rules of the database's locale. upper('tom') → TOM ``` You can see how Materialize have addressed it: https://github.com/MaterializeInc/materialize/blob/main/LICENSE#L327. Comment: ``` /// Converts the string to all upper case. /// upper('tom') = 'TOM' ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
