jarohen commented on code in PR #40987:
URL: https://github.com/apache/arrow/pull/40987#discussion_r1551282251
##########
java/vector/src/test/java/org/apache/arrow/vector/ipc/BaseFileTest.java:
##########
@@ -109,12 +114,13 @@ public void tearDown() {
}
- private static short [] uint1Values = new short[]{0, 255, 1, 128, 2};
- private static char [] uint2Values = new char[]{0, Character.MAX_VALUE, 1,
Short.MAX_VALUE * 2, 2};
- private static long [] uint4Values = new long[]{0, Integer.MAX_VALUE + 1L,
1, Integer.MAX_VALUE * 2L, 2};
- private static BigInteger[] uint8Values = new
BigInteger[]{BigInteger.valueOf(0),
+ private static final short [] uint1Values = new short[]{0, 255, 1, 128, 2};
+ private static final char [] uint2Values = new char[]{0,
Character.MAX_VALUE, 1, Short.MAX_VALUE * 2, 2};
+ private static final long [] uint4Values = new long[]{0, Integer.MAX_VALUE +
1L, 1, Integer.MAX_VALUE * 2L, 2};
+ private static final BigInteger[] uint8Values = new
BigInteger[]{BigInteger.valueOf(0),
BigInteger.valueOf(Long.MAX_VALUE).multiply(BigInteger.valueOf(2)),
BigInteger.valueOf(2),
BigInteger.valueOf(Long.MAX_VALUE).add(BigInteger.valueOf(1)),
BigInteger.valueOf(2)};
+ private static final UUID[] uuidValues = new UUID[] {UUID.randomUUID(),
UUID.randomUUID(), UUID.randomUUID()};
Review Comment:
@vibhatha if it doesn't, it's time to buy a lottery ticket
:slightly_smiling_face:
Joking aside, yeah, we don't need three unique values - what matters is that
the values get round-tripped. That said, we could hard-code a few UUID literals?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
