pitrou commented on code in PR #40987:
URL: https://github.com/apache/arrow/pull/40987#discussion_r1551750117


##########
java/vector/src/main/java/org/apache/arrow/vector/ipc/JsonFileWriter.java:
##########
@@ -208,6 +210,10 @@ private void writeBatch(VectorSchemaRoot recordBatch) 
throws IOException {
   }
 
   private void writeFromVectorIntoJson(Field field, FieldVector vector) throws 
IOException {
+    if (vector instanceof ExtensionTypeVector) {

Review Comment:
   I'm curious why this is needed, because roundtripping works in our 
integration tests:
   
https://github.com/apache/arrow/blob/b99b00dd66586cf54b04ce6a51eb1cf68b1510a3/dev/archery/archery/integration/datagen.py#L1845-L1861



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to