normanj-bitquill commented on code in PR #40988:
URL: https://github.com/apache/arrow/pull/40988#discussion_r1551960883
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadata.java:
##########
@@ -754,7 +754,11 @@ private <T> T getSqlInfoAndCacheIfCacheIsEmpty(final
SqlInfo sqlInfoCommand,
}
private String convertListSqlInfoToString(final List<?> sqlInfoList) {
Review Comment:
This method is used by these methods:
* getSqlKeywords()
* getNumericFunctions()
* getStringFunctions()
* getSystemFunctions()
* getTimeDateFunctions()
These methods come from Avatica, so we can't easily change the return type.
https://javadoc.io/static/org.apache.calcite.avatica/avatica-core/1.24.0/org/apache/calcite/avatica/AvaticaDatabaseMetaData.html#getSQLKeywords--
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
