lidavidm commented on code in PR #40988:
URL: https://github.com/apache/arrow/pull/40988#discussion_r1552519380
##########
java/flight/flight-sql-jdbc-core/src/main/java/org/apache/arrow/driver/jdbc/ArrowDatabaseMetadata.java:
##########
@@ -754,7 +754,11 @@ private <T> T getSqlInfoAndCacheIfCacheIsEmpty(final
SqlInfo sqlInfoCommand,
}
private String convertListSqlInfoToString(final List<?> sqlInfoList) {
Review Comment:
But we can update our implementations to be explicit, right?
In any case, defaulting to an empty string also seems fine so long as it's
documented in the helper's docstring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
