nealrichardson commented on code in PR #41019:
URL: https://github.com/apache/arrow/pull/41019#discussion_r1553495249
##########
r/R/install-arrow.R:
##########
@@ -76,22 +76,15 @@ install_arrow <- function(nightly = FALSE,
ARROW_R_DEV = verbose,
ARROW_USE_PKG_CONFIG = use_system
)
- # On the M1, we can't use the usual autobrew, which pulls Intel
dependencies
- apple_m1 <- grepl("arm-apple|aarch64.*darwin", R.Version()$platform)
# On Rosetta, we have to build without JEMALLOC, so we also can't autobrew
rosetta <- on_rosetta()
if (rosetta) {
Review Comment:
```suggestion
if (on_rosetta()) {
```
##########
r/R/install-arrow.R:
##########
@@ -76,22 +76,15 @@ install_arrow <- function(nightly = FALSE,
ARROW_R_DEV = verbose,
ARROW_USE_PKG_CONFIG = use_system
)
- # On the M1, we can't use the usual autobrew, which pulls Intel
dependencies
- apple_m1 <- grepl("arm-apple|aarch64.*darwin", R.Version()$platform)
# On Rosetta, we have to build without JEMALLOC, so we also can't autobrew
rosetta <- on_rosetta()
if (rosetta) {
Sys.setenv(ARROW_JEMALLOC = "OFF")
- }
- if (apple_m1 || rosetta) {
Sys.setenv(FORCE_BUNDLED_BUILD = "true")
Review Comment:
This is probably also about autobrew right?
```suggestion
```
##########
r/R/install-arrow.R:
##########
@@ -76,22 +76,15 @@ install_arrow <- function(nightly = FALSE,
ARROW_R_DEV = verbose,
ARROW_USE_PKG_CONFIG = use_system
)
- # On the M1, we can't use the usual autobrew, which pulls Intel
dependencies
- apple_m1 <- grepl("arm-apple|aarch64.*darwin", R.Version()$platform)
# On Rosetta, we have to build without JEMALLOC, so we also can't autobrew
Review Comment:
```suggestion
# On Rosetta, we have to build without JEMALLOC
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
