jonkeane commented on code in PR #41019:
URL: https://github.com/apache/arrow/pull/41019#discussion_r1553596591
##########
r/R/install-arrow.R:
##########
@@ -76,22 +76,15 @@ install_arrow <- function(nightly = FALSE,
ARROW_R_DEV = verbose,
ARROW_USE_PKG_CONFIG = use_system
)
- # On the M1, we can't use the usual autobrew, which pulls Intel
dependencies
- apple_m1 <- grepl("arm-apple|aarch64.*darwin", R.Version()$platform)
# On Rosetta, we have to build without JEMALLOC, so we also can't autobrew
rosetta <- on_rosetta()
if (rosetta) {
Sys.setenv(ARROW_JEMALLOC = "OFF")
- }
- if (apple_m1 || rosetta) {
Sys.setenv(FORCE_BUNDLED_BUILD = "true")
Review Comment:
I'm pretty sure it is, but when I git blamed it wasn't clear that's the only
reason for it. I can pull it out, but also we probably should just remove all
of the rosetta building code entirely at some point since it's not really a
supported setup. I'll add an issue to come back to this (+ various other places
we have it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
