pitrou commented on code in PR #40761: URL: https://github.com/apache/arrow/pull/40761#discussion_r1553576958
########## python/pyarrow/types.py: ########## @@ -59,92 +69,92 @@ def is_null(t): @doc(is_null, datatype="boolean") def is_boolean(t): - return t.id == lib.Type_BOOL + return _is_primitive(t) and _bit_width(t) == 1 Review Comment: No, it means you would define `is_boolean` directly in `types.pxi`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
