pitrou commented on code in PR #40761:
URL: https://github.com/apache/arrow/pull/40761#discussion_r1557963435
##########
python/pyarrow/types.pxi:
##########
@@ -5401,6 +5428,1069 @@ def is_float_value(object obj):
return IsPyFloat(obj)
+def _is_integer(data_type):
+ """
+ This function checks whether the `data_type` is an integer type, which
+ includes signed and unsigned integers of various bit widths (8, 16, 32, 64
bits).
Review Comment:
We can probably keep the original wording, which is more terse and as
informative:
```suggestion
Return whether the `data_type` is an integer type.
```
##########
python/pyarrow/tests/test_types.py:
##########
@@ -94,39 +93,39 @@ def get_many_types():
def test_is_boolean():
- assert types.is_boolean(pa.bool_())
- assert not types.is_boolean(pa.int8())
+ assert pa.types.is_boolean(pa.bool_())
Review Comment:
Are these changes necessary for some reason? They are not problematic, but
they don't seem required either.
##########
python/pyarrow/types.py:
##########
@@ -20,295 +20,54 @@
from pyarrow.lib import (is_boolean_value, # noqa
is_integer_value,
- is_float_value)
-
-import pyarrow.lib as lib
-from pyarrow.util import doc
-
-
-_SIGNED_INTEGER_TYPES = {lib.Type_INT8, lib.Type_INT16, lib.Type_INT32,
- lib.Type_INT64}
-_UNSIGNED_INTEGER_TYPES = {lib.Type_UINT8, lib.Type_UINT16, lib.Type_UINT32,
- lib.Type_UINT64}
-_INTEGER_TYPES = _SIGNED_INTEGER_TYPES | _UNSIGNED_INTEGER_TYPES
-_FLOATING_TYPES = {lib.Type_HALF_FLOAT, lib.Type_FLOAT, lib.Type_DOUBLE}
-_DECIMAL_TYPES = {lib.Type_DECIMAL128, lib.Type_DECIMAL256}
-_DATE_TYPES = {lib.Type_DATE32, lib.Type_DATE64}
-_TIME_TYPES = {lib.Type_TIME32, lib.Type_TIME64}
-_INTERVAL_TYPES = {lib.Type_INTERVAL_MONTH_DAY_NANO}
-_TEMPORAL_TYPES = ({lib.Type_TIMESTAMP,
- lib.Type_DURATION} | _TIME_TYPES | _DATE_TYPES |
- _INTERVAL_TYPES)
-_UNION_TYPES = {lib.Type_SPARSE_UNION, lib.Type_DENSE_UNION}
-_NESTED_TYPES = {lib.Type_LIST, lib.Type_FIXED_SIZE_LIST, lib.Type_LARGE_LIST,
- lib.Type_LIST_VIEW, lib.Type_LARGE_LIST_VIEW,
- lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
-
-
-@doc(datatype="null")
-def is_null(t):
- """
- Return True if value is an instance of type: {datatype}.
-
- Parameters
- ----------
- t : DataType
- """
- return t.id == lib.Type_NA
-
-
-@doc(is_null, datatype="boolean")
-def is_boolean(t):
- return t.id == lib.Type_BOOL
-
-
-@doc(is_null, datatype="any integer")
-def is_integer(t):
- return t.id in _INTEGER_TYPES
-
-
-@doc(is_null, datatype="signed integer")
-def is_signed_integer(t):
- return t.id in _SIGNED_INTEGER_TYPES
-
-
-@doc(is_null, datatype="unsigned integer")
-def is_unsigned_integer(t):
- return t.id in _UNSIGNED_INTEGER_TYPES
-
-
-@doc(is_null, datatype="int8")
-def is_int8(t):
- return t.id == lib.Type_INT8
-
-
-@doc(is_null, datatype="int16")
-def is_int16(t):
- return t.id == lib.Type_INT16
-
-
-@doc(is_null, datatype="int32")
-def is_int32(t):
- return t.id == lib.Type_INT32
-
-
-@doc(is_null, datatype="int64")
-def is_int64(t):
- return t.id == lib.Type_INT64
-
-
-@doc(is_null, datatype="uint8")
-def is_uint8(t):
- return t.id == lib.Type_UINT8
-
-
-@doc(is_null, datatype="uint16")
-def is_uint16(t):
- return t.id == lib.Type_UINT16
-
-
-@doc(is_null, datatype="uint32")
-def is_uint32(t):
- return t.id == lib.Type_UINT32
-
-
-@doc(is_null, datatype="uint64")
-def is_uint64(t):
- return t.id == lib.Type_UINT64
-
-
-@doc(is_null, datatype="floating point numeric")
-def is_floating(t):
- return t.id in _FLOATING_TYPES
-
-
-@doc(is_null, datatype="float16 (half-precision)")
-def is_float16(t):
- return t.id == lib.Type_HALF_FLOAT
-
-
-@doc(is_null, datatype="float32 (single precision)")
-def is_float32(t):
- return t.id == lib.Type_FLOAT
-
-
-@doc(is_null, datatype="float64 (double precision)")
-def is_float64(t):
- return t.id == lib.Type_DOUBLE
-
-
-@doc(is_null, datatype="list")
-def is_list(t):
- return t.id == lib.Type_LIST
-
-
-@doc(is_null, datatype="large list")
-def is_large_list(t):
- return t.id == lib.Type_LARGE_LIST
-
-
-@doc(is_null, datatype="fixed size list")
-def is_fixed_size_list(t):
- return t.id == lib.Type_FIXED_SIZE_LIST
-
-
-@doc(is_null, datatype="list view")
-def is_list_view(t):
- return t.id == lib.Type_LIST_VIEW
-
-
-@doc(is_null, datatype="large list view")
-def is_large_list_view(t):
- return t.id == lib.Type_LARGE_LIST_VIEW
-
-
-@doc(is_null, datatype="struct")
-def is_struct(t):
- return t.id == lib.Type_STRUCT
-
-
-@doc(is_null, datatype="union")
-def is_union(t):
- return t.id in _UNION_TYPES
-
-
-@doc(is_null, datatype="nested type")
-def is_nested(t):
- return t.id in _NESTED_TYPES
-
-
-@doc(is_null, datatype="run-end encoded")
-def is_run_end_encoded(t):
- return t.id == lib.Type_RUN_END_ENCODED
-
-
-@doc(is_null, datatype="date, time, timestamp or duration")
-def is_temporal(t):
- return t.id in _TEMPORAL_TYPES
-
-
-@doc(is_null, datatype="timestamp")
-def is_timestamp(t):
- return t.id == lib.Type_TIMESTAMP
-
-
-@doc(is_null, datatype="duration")
-def is_duration(t):
- return t.id == lib.Type_DURATION
-
-
-@doc(is_null, datatype="time")
-def is_time(t):
- return t.id in _TIME_TYPES
-
-
-@doc(is_null, datatype="time32")
-def is_time32(t):
- return t.id == lib.Type_TIME32
-
-
-@doc(is_null, datatype="time64")
-def is_time64(t):
- return t.id == lib.Type_TIME64
-
-
-@doc(is_null, datatype="variable-length binary")
-def is_binary(t):
- return t.id == lib.Type_BINARY
-
-
-@doc(is_null, datatype="large variable-length binary")
-def is_large_binary(t):
- return t.id == lib.Type_LARGE_BINARY
-
-
-@doc(method="is_string")
-def is_unicode(t):
- """
- Alias for {method}.
-
- Parameters
- ----------
- t : DataType
- """
- return is_string(t)
-
-
-@doc(is_null, datatype="string (utf8 unicode)")
-def is_string(t):
- return t.id == lib.Type_STRING
-
-
-@doc(is_unicode, method="is_large_string")
-def is_large_unicode(t):
- return is_large_string(t)
-
-
-@doc(is_null, datatype="large string (utf8 unicode)")
-def is_large_string(t):
- return t.id == lib.Type_LARGE_STRING
-
-
-@doc(is_null, datatype="fixed size binary")
-def is_fixed_size_binary(t):
- return t.id == lib.Type_FIXED_SIZE_BINARY
-
-
-@doc(is_null, datatype="variable-length binary view")
-def is_binary_view(t):
- return t.id == lib.Type_BINARY_VIEW
-
-
-@doc(is_null, datatype="variable-length string (utf-8) view")
-def is_string_view(t):
- return t.id == lib.Type_STRING_VIEW
-
-
-@doc(is_null, datatype="date")
-def is_date(t):
- return t.id in _DATE_TYPES
-
-
-@doc(is_null, datatype="date32 (days)")
-def is_date32(t):
- return t.id == lib.Type_DATE32
-
-
-@doc(is_null, datatype="date64 (milliseconds)")
-def is_date64(t):
- return t.id == lib.Type_DATE64
-
-
-@doc(is_null, datatype="map")
-def is_map(t):
- return t.id == lib.Type_MAP
-
-
-@doc(is_null, datatype="decimal")
-def is_decimal(t):
- return t.id in _DECIMAL_TYPES
-
-
-@doc(is_null, datatype="decimal128")
-def is_decimal128(t):
- return t.id == lib.Type_DECIMAL128
-
-
-@doc(is_null, datatype="decimal256")
-def is_decimal256(t):
- return t.id == lib.Type_DECIMAL256
-
-
-@doc(is_null, datatype="dictionary-encoded")
-def is_dictionary(t):
- return t.id == lib.Type_DICTIONARY
-
-
-@doc(is_null, datatype="interval")
-def is_interval(t):
- return t.id == lib.Type_INTERVAL_MONTH_DAY_NANO
-
-
-@doc(is_null, datatype="primitive type")
-def is_primitive(t):
- return lib._is_primitive(t.id)
+ is_float_value,
+ ensure_type,
+ _is_integer as is_integer,
Review Comment:
You can simply define those without a leading underscore in `types.pxi`.
This will simplify the imports.
##########
python/pyarrow/types.py:
##########
@@ -20,295 +20,54 @@
from pyarrow.lib import (is_boolean_value, # noqa
is_integer_value,
- is_float_value)
-
-import pyarrow.lib as lib
-from pyarrow.util import doc
-
-
-_SIGNED_INTEGER_TYPES = {lib.Type_INT8, lib.Type_INT16, lib.Type_INT32,
- lib.Type_INT64}
-_UNSIGNED_INTEGER_TYPES = {lib.Type_UINT8, lib.Type_UINT16, lib.Type_UINT32,
- lib.Type_UINT64}
-_INTEGER_TYPES = _SIGNED_INTEGER_TYPES | _UNSIGNED_INTEGER_TYPES
-_FLOATING_TYPES = {lib.Type_HALF_FLOAT, lib.Type_FLOAT, lib.Type_DOUBLE}
-_DECIMAL_TYPES = {lib.Type_DECIMAL128, lib.Type_DECIMAL256}
-_DATE_TYPES = {lib.Type_DATE32, lib.Type_DATE64}
-_TIME_TYPES = {lib.Type_TIME32, lib.Type_TIME64}
-_INTERVAL_TYPES = {lib.Type_INTERVAL_MONTH_DAY_NANO}
-_TEMPORAL_TYPES = ({lib.Type_TIMESTAMP,
- lib.Type_DURATION} | _TIME_TYPES | _DATE_TYPES |
- _INTERVAL_TYPES)
-_UNION_TYPES = {lib.Type_SPARSE_UNION, lib.Type_DENSE_UNION}
-_NESTED_TYPES = {lib.Type_LIST, lib.Type_FIXED_SIZE_LIST, lib.Type_LARGE_LIST,
- lib.Type_LIST_VIEW, lib.Type_LARGE_LIST_VIEW,
- lib.Type_STRUCT, lib.Type_MAP} | _UNION_TYPES
-
-
-@doc(datatype="null")
-def is_null(t):
- """
- Return True if value is an instance of type: {datatype}.
-
- Parameters
- ----------
- t : DataType
- """
- return t.id == lib.Type_NA
-
-
-@doc(is_null, datatype="boolean")
-def is_boolean(t):
- return t.id == lib.Type_BOOL
-
-
-@doc(is_null, datatype="any integer")
-def is_integer(t):
- return t.id in _INTEGER_TYPES
-
-
-@doc(is_null, datatype="signed integer")
-def is_signed_integer(t):
- return t.id in _SIGNED_INTEGER_TYPES
-
-
-@doc(is_null, datatype="unsigned integer")
-def is_unsigned_integer(t):
- return t.id in _UNSIGNED_INTEGER_TYPES
-
-
-@doc(is_null, datatype="int8")
-def is_int8(t):
- return t.id == lib.Type_INT8
-
-
-@doc(is_null, datatype="int16")
-def is_int16(t):
- return t.id == lib.Type_INT16
-
-
-@doc(is_null, datatype="int32")
-def is_int32(t):
- return t.id == lib.Type_INT32
-
-
-@doc(is_null, datatype="int64")
-def is_int64(t):
- return t.id == lib.Type_INT64
-
-
-@doc(is_null, datatype="uint8")
-def is_uint8(t):
- return t.id == lib.Type_UINT8
-
-
-@doc(is_null, datatype="uint16")
-def is_uint16(t):
- return t.id == lib.Type_UINT16
-
-
-@doc(is_null, datatype="uint32")
-def is_uint32(t):
- return t.id == lib.Type_UINT32
-
-
-@doc(is_null, datatype="uint64")
-def is_uint64(t):
- return t.id == lib.Type_UINT64
-
-
-@doc(is_null, datatype="floating point numeric")
-def is_floating(t):
- return t.id in _FLOATING_TYPES
-
-
-@doc(is_null, datatype="float16 (half-precision)")
-def is_float16(t):
- return t.id == lib.Type_HALF_FLOAT
-
-
-@doc(is_null, datatype="float32 (single precision)")
-def is_float32(t):
- return t.id == lib.Type_FLOAT
-
-
-@doc(is_null, datatype="float64 (double precision)")
-def is_float64(t):
- return t.id == lib.Type_DOUBLE
-
-
-@doc(is_null, datatype="list")
-def is_list(t):
- return t.id == lib.Type_LIST
-
-
-@doc(is_null, datatype="large list")
-def is_large_list(t):
- return t.id == lib.Type_LARGE_LIST
-
-
-@doc(is_null, datatype="fixed size list")
-def is_fixed_size_list(t):
- return t.id == lib.Type_FIXED_SIZE_LIST
-
-
-@doc(is_null, datatype="list view")
-def is_list_view(t):
- return t.id == lib.Type_LIST_VIEW
-
-
-@doc(is_null, datatype="large list view")
-def is_large_list_view(t):
- return t.id == lib.Type_LARGE_LIST_VIEW
-
-
-@doc(is_null, datatype="struct")
-def is_struct(t):
- return t.id == lib.Type_STRUCT
-
-
-@doc(is_null, datatype="union")
-def is_union(t):
- return t.id in _UNION_TYPES
-
-
-@doc(is_null, datatype="nested type")
-def is_nested(t):
- return t.id in _NESTED_TYPES
-
-
-@doc(is_null, datatype="run-end encoded")
-def is_run_end_encoded(t):
- return t.id == lib.Type_RUN_END_ENCODED
-
-
-@doc(is_null, datatype="date, time, timestamp or duration")
-def is_temporal(t):
- return t.id in _TEMPORAL_TYPES
-
-
-@doc(is_null, datatype="timestamp")
-def is_timestamp(t):
- return t.id == lib.Type_TIMESTAMP
-
-
-@doc(is_null, datatype="duration")
-def is_duration(t):
- return t.id == lib.Type_DURATION
-
-
-@doc(is_null, datatype="time")
-def is_time(t):
- return t.id in _TIME_TYPES
-
-
-@doc(is_null, datatype="time32")
-def is_time32(t):
- return t.id == lib.Type_TIME32
-
-
-@doc(is_null, datatype="time64")
-def is_time64(t):
- return t.id == lib.Type_TIME64
-
-
-@doc(is_null, datatype="variable-length binary")
-def is_binary(t):
- return t.id == lib.Type_BINARY
-
-
-@doc(is_null, datatype="large variable-length binary")
-def is_large_binary(t):
- return t.id == lib.Type_LARGE_BINARY
-
-
-@doc(method="is_string")
-def is_unicode(t):
- """
- Alias for {method}.
-
- Parameters
- ----------
- t : DataType
- """
- return is_string(t)
-
-
-@doc(is_null, datatype="string (utf8 unicode)")
-def is_string(t):
- return t.id == lib.Type_STRING
-
-
-@doc(is_unicode, method="is_large_string")
-def is_large_unicode(t):
- return is_large_string(t)
-
-
-@doc(is_null, datatype="large string (utf8 unicode)")
-def is_large_string(t):
- return t.id == lib.Type_LARGE_STRING
-
-
-@doc(is_null, datatype="fixed size binary")
-def is_fixed_size_binary(t):
- return t.id == lib.Type_FIXED_SIZE_BINARY
-
-
-@doc(is_null, datatype="variable-length binary view")
-def is_binary_view(t):
- return t.id == lib.Type_BINARY_VIEW
-
-
-@doc(is_null, datatype="variable-length string (utf-8) view")
-def is_string_view(t):
- return t.id == lib.Type_STRING_VIEW
-
-
-@doc(is_null, datatype="date")
-def is_date(t):
- return t.id in _DATE_TYPES
-
-
-@doc(is_null, datatype="date32 (days)")
-def is_date32(t):
- return t.id == lib.Type_DATE32
-
-
-@doc(is_null, datatype="date64 (milliseconds)")
-def is_date64(t):
- return t.id == lib.Type_DATE64
-
-
-@doc(is_null, datatype="map")
-def is_map(t):
- return t.id == lib.Type_MAP
-
-
-@doc(is_null, datatype="decimal")
-def is_decimal(t):
- return t.id in _DECIMAL_TYPES
-
-
-@doc(is_null, datatype="decimal128")
-def is_decimal128(t):
- return t.id == lib.Type_DECIMAL128
-
-
-@doc(is_null, datatype="decimal256")
-def is_decimal256(t):
- return t.id == lib.Type_DECIMAL256
-
-
-@doc(is_null, datatype="dictionary-encoded")
-def is_dictionary(t):
- return t.id == lib.Type_DICTIONARY
-
-
-@doc(is_null, datatype="interval")
-def is_interval(t):
- return t.id == lib.Type_INTERVAL_MONTH_DAY_NANO
-
-
-@doc(is_null, datatype="primitive type")
-def is_primitive(t):
- return lib._is_primitive(t.id)
+ is_float_value,
+ ensure_type,
Review Comment:
Despite not beginning with a underscore, this is not a public function, so
we should not export it.
##########
python/pyarrow/types.pxi:
##########
@@ -5401,6 +5428,1069 @@ def is_float_value(object obj):
return IsPyFloat(obj)
+def _is_integer(data_type):
+ """
+ This function checks whether the `data_type` is an integer type, which
+ includes signed and unsigned integers of various bit widths (8, 16, 32, 64
bits).
Review Comment:
Same for other functions below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
