zeroshade commented on code in PR #40807:
URL: https://github.com/apache/arrow/pull/40807#discussion_r1553831336
##########
cpp/src/arrow/record_batch.h:
##########
@@ -300,6 +311,11 @@ class ARROW_EXPORT RecordBatchReader {
/// \brief finalize reader
virtual Status Close() { return Status::OK(); }
+ /// \brief Get the device type for record batches this reader produces
+ ///
+ /// default implementation is to return ARROW_DEVICE_CPU
+ virtual DeviceAllocationType device_type() const { return
DeviceAllocationType::kCPU; }
Review Comment:
So the suggestion is we *should* add a `device_type` member to the
`RecordBatch` class and have it be provided?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
