zeroshade commented on code in PR #40807: URL: https://github.com/apache/arrow/pull/40807#discussion_r1553909516
########## cpp/src/arrow/record_batch.h: ########## @@ -23,6 +23,7 @@ #include <vector> #include "arrow/compare.h" +#include "arrow/device.h" Review Comment: We would have to move the nested `Device::SyncEvent` outside of the `Device` class to do that since you can't forward declare an inner class like that. It would also require pushing the entire `DeviceAllocationType` declaration to `type_fwd.h` which I'm not sure if we want to do. So I don't think we can do this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
