JasonLi-cn commented on code in PR #9971:
URL: https://github.com/apache/arrow-datafusion/pull/9971#discussion_r1554794722
##########
datafusion/functions/src/string/lower.rs:
##########
@@ -62,6 +62,6 @@ impl ScalarUDFImpl for LowerFunc {
}
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
- handle(args, |string| string.to_lowercase(), "lower")
+ case_conversion(args, |string| string.to_lowercase(), "lower")
Review Comment:
Thank you @alamb for pointing out the mistake. In order to achieve this
optimization, do you agree to implement the `to_lower` and `to_upper` functions
by emulating the str's `to_lowercase` and `to_uppercase` functions,
respectively?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
