alamb commented on code in PR #9971:
URL: https://github.com/apache/arrow-datafusion/pull/9971#discussion_r1555017224
##########
datafusion/functions/src/string/lower.rs:
##########
@@ -62,6 +62,6 @@ impl ScalarUDFImpl for LowerFunc {
}
fn invoke(&self, args: &[ColumnarValue]) -> Result<ColumnarValue> {
- handle(args, |string| string.to_lowercase(), "lower")
+ case_conversion(args, |string| string.to_lowercase(), "lower")
Review Comment:
Maybe we can take some inspiration from how `to_uppercase` is implemented:
https://doc.rust-lang.org/src/alloc/str.rs.html#368
It seems like it should take advantage of the case case where the string is
entirely ASCII
Perhaps you can use `StringArrayBuilder` added in
https://github.com/apache/arrow-datafusion/pull/9732, to copy data, adjusting
the offsets if necessary 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
