verma-kartik commented on issue #40563: URL: https://github.com/apache/arrow/issues/40563#issuecomment-2041567702
@zeroshade @xxgreg I would like to make the above changes. I can assign myself via `take` right? Also, I tried the changes on local, and the change is working as expected. I observed that: 1. I did not find any unit test for `MarshalJSON()` and `UnmarshalJSON`, shall I also add them to for this issue? 2. /go/arrow/array has separate files for handling Float16 data type, but Float32, Float64, and others are together in numeric.gen.go. Is there an explicit reason to do so or just technical debt to break numeric.gen.go in multiple files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
