zeroshade commented on issue #40563: URL: https://github.com/apache/arrow/issues/40563#issuecomment-2041584430
Hey @verma-kartik, using `take` would indeed assign yourself to this issue. It would also assign you automatically if you file a PR containing `GH-30563` in it's title. As for your observations: > There are not any unit tests for MarshalJSON() and UnmarshalJSON, shall I also add them to for this issue? While there aren't tests that `explicitly` call `MarshalJSON` and `UnmarshalJSON` they are both indirectly tested via https://github.com/apache/arrow/blob/main/go/arrow/array/util_test.go and https://github.com/apache/arrow/blob/main/go/arrow/array/json_reader_test.go which call `FromJSON`, use `json.Marshal` and use a `json.Reader` respectively. So you should be able to add the relevant tests for this into one of those files. > 2. /go/arrow/array has separate files for handling Float16 data type, but Float32, Float64, and others are together in numeric.gen.go. Is there an explicit reason to do so or just technical debt to break numeric.gen.go in multiple files? The reason why Float16 is separate from those is due to the fact that the code gen has to handle `float16.Num` as opposed to just using `float16` like it can do with the other data types which are native. Ideally, the technical debt here would be to replace the `numeric.gen.go` file to utilize Go generics instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
