lidavidm commented on code in PR #40340:
URL: https://github.com/apache/arrow/pull/40340#discussion_r1555425467
##########
java/vector/src/main/codegen/templates/ValueHolders.java:
##########
@@ -40,11 +42,18 @@ public final class ${className} implements ValueHolder{
/** The last index (exclusive) into the Vector. **/
public int end;
-
+
/** The Vector holding the actual values. **/
public ${minor.class}Vector vector;
-
+
<#else>
+
+ <#if minor.class == "ViewVarChar" || minor.class == "ViewVarBinary">
+ public HolderCallback callBack;
Review Comment:
I don't see why the fields can't directly be in the holder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
