vibhatha commented on code in PR #40340:
URL: https://github.com/apache/arrow/pull/40340#discussion_r1555435685
##########
java/vector/src/main/codegen/templates/ValueHolders.java:
##########
@@ -40,11 +42,18 @@ public final class ${className} implements ValueHolder{
/** The last index (exclusive) into the Vector. **/
public int end;
-
+
/** The Vector holding the actual values. **/
public ${minor.class}Vector vector;
-
+
<#else>
+
+ <#if minor.class == "ViewVarChar" || minor.class == "ViewVarBinary">
+ public HolderCallback callBack;
Review Comment:
Not the fields the way to get the required value? In other cases knowing
offset and length is sufficient. But here we have to retrieve buf index, offset
and then get the value. Do we expect user to do it themselves? Am I
understanding the holder wrong way here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
