sgilmore10 commented on code in PR #40956:
URL: https://github.com/apache/arrow/pull/40956#discussion_r1555906089
##########
dev/release/05-binary-upload.sh:
##########
@@ -135,3 +136,18 @@ docker_run \
VERBOSE=${VERBOSE:-no} \
VERSION=${version} \
YUM_TARGETS=$(IFS=,; echo "${yum_targets[*]}")
+
+# Create a git tag to associate with a GitHub Release that will
+# have the release candidate MLTBX file as an asset.
+#
+# Push this tag (e.g. apache-arrow-15.0.2-rc0) to the remote
+# apache/arrow repository to trigger the GitHub Actions Workflow
+# that creates the GitHub Release and uploads the MLTBX file.
+#
+# See .github/workflows/package.yml for details.
+if [ ${UPLOAD_MATLAB} -gt 0 ]; then
+ release_tag="apache-arrow-${version_with_rc}"
+ tag_message="Release candidate: ${version_with_rc}"
+ git tag -a ${release_tag} -m ${tag_message}
+ git push apache ${release_tag}
Review Comment:
Hi @kou,
Thanks for sharing this diff! We just have one clarification question:
Based on the diff you shared, it looks like you want us to replace the
`release_tag` with the `rc_tag`. Did you mean for us to actually add the
`rc_tag` in addition to the `release_tag`? We asking because we assume we
still want to create a `release_tag`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
