kou commented on code in PR #40956:
URL: https://github.com/apache/arrow/pull/40956#discussion_r1556447060
##########
dev/release/05-binary-upload.sh:
##########
@@ -135,3 +136,18 @@ docker_run \
VERBOSE=${VERBOSE:-no} \
VERSION=${version} \
YUM_TARGETS=$(IFS=,; echo "${yum_targets[*]}")
+
+# Create a git tag to associate with a GitHub Release that will
+# have the release candidate MLTBX file as an asset.
+#
+# Push this tag (e.g. apache-arrow-15.0.2-rc0) to the remote
+# apache/arrow repository to trigger the GitHub Actions Workflow
+# that creates the GitHub Release and uploads the MLTBX file.
+#
+# See .github/workflows/package.yml for details.
+if [ ${UPLOAD_MATLAB} -gt 0 ]; then
+ release_tag="apache-arrow-${version_with_rc}"
+ tag_message="Release candidate: ${version_with_rc}"
+ git tag -a ${release_tag} -m ${tag_message}
+ git push apache ${release_tag}
Review Comment:
> Did you mean for us to actually add the `rc_tag` in addition to the
`release_tag`?
No. I mean for us to replace the `release_tag` with `rc_tag`.
> We asking because we assume we still want to create a `release_tag`.
I want to change the current workflow:
1. Create a `apache-arrow-X.Y.Z` tag for X.Y.Z RC0
2. (Found a problem for X.Y.Z RC0)
3. Remove the `apache-arrow-X.Y.Z` tag for X.Y.Z RC0
4. Create a `apache-arrow-X.Y.Z` tag for X.Y.Z RC1
5. ...
to the following:
1. Create a `apache-arrow-X.Y.Z-rc0` tag for X.Y.Z RC0
2. (Found a problem for X.Y.Z RC0)
3. Create a `apache-arrow-X.Y.Z-rc1` tag for X.Y.Z RC1
4. Vote
5. Passed
6. Create a `apache-arrow-X.Y.Z` tag from `apache-arrow-X.Y.Z-rc1` like
apache/arrow-adbc and apache/arrow-flight-sql-postgresql do
Hmm. It's better that we handle the workflow change related task in a
separated issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
