jayzhan211 commented on code in PR #9980:
URL: https://github.com/apache/arrow-datafusion/pull/9980#discussion_r1557712998
##########
datafusion/functions-array/src/lib.rs:
##########
@@ -139,13 +326,16 @@ pub fn register_all(registry: &mut dyn FunctionRegistry)
-> Result<()> {
replace::array_replace_all_udf(),
replace::array_replace_udf(),
];
+
+ // TODO: Remove. Define in array_functions directly
functions.into_iter().try_for_each(|udf| {
Review Comment:
We are register functions here, so instantiation should we avoided. Only
when we call `get_udf`, is time we instantiate the function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
