alamb commented on code in PR #9980:
URL: https://github.com/apache/arrow-datafusion/pull/9980#discussion_r1559821211
##########
datafusion/functions-array/src/lib.rs:
##########
@@ -139,13 +326,16 @@ pub fn register_all(registry: &mut dyn FunctionRegistry)
-> Result<()> {
replace::array_replace_all_udf(),
replace::array_replace_udf(),
];
+
+ // TODO: Remove. Define in array_functions directly
functions.into_iter().try_for_each(|udf| {
Review Comment:
Maybe it is worth clarifying if the goal is to when we are trying to avoi
instantiating `ScalarUDF`
It seems like it could be either:
1. When we have a physical plan already (aka as in Comet) and need to look
up a function by name (but not iterate through the entire list)
2. Any time a `SessionContext` is created (aka make FunctionFactory handle
deferred registrations too).
I can see the usecase for 1, I am not sure about for 2 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
