alamb commented on code in PR #10016:
URL:
https://github.com/apache/arrow-datafusion/pull/10016#discussion_r1557811475
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -1578,33 +1593,6 @@ impl LogicalPlan {
})
.map(|_| param_types)
}
-
- /// Return an Expr with all placeholders replaced with their
- /// corresponding values provided in the params_values
- fn replace_placeholders_with_values(
- expr: Expr,
- param_values: &ParamValues,
- ) -> Result<Expr> {
- expr.transform(&|expr| {
Review Comment:
rewrite_with_subqueries handles recursing into the subqueries so this is no
longer necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
