felipecrv commented on code in PR #41092:
URL: https://github.com/apache/arrow/pull/41092#discussion_r1558130947
##########
cpp/src/arrow/array/array_nested.cc:
##########
@@ -216,12 +216,26 @@ static std::shared_ptr<Array> SliceArrayWithOffsets(const
Array& array, int64_t
return array.Slice(begin, end - begin);
}
+namespace {
+struct FlattenWithRecursion {
+ // Flatten all list-like types array recursively
+ static Result<std::shared_ptr<Array>> Flatten(const Array& array, bool
with_recursion,
+ MemoryPool* memory_pool);
+};
+} // namespace
Review Comment:
I'm suggesting `LogicalList` instead of `ListLike` because the
`is_list_like` type predicate (that we can't change for backwards compatibility
reasons) doesn't include list-views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
