felipecrv commented on PR #41092: URL: https://github.com/apache/arrow/pull/41092#issuecomment-2045869570
> > I don't know, I think if we want to implement that: > > > > 1. For function, we can support option > > 2. For underlying impl, a new interface > > For 1, adder a new `FlattenRecursion` function with same underlying implementation as `Flatten` and keep the origin function for compatible with pyarrow python interface. At the `builder_nested.h` level, I don't think `bool` parameters controlling recursion are necessary/desirable. Perhaps at the kernels API level (with the addition of an options_class for the `"list_flatten"` function) or at the `pyarrow` bindings. The default value for `bool recursive` on these 2 should be `false` so old behavior is preserved unless users opt-in to the recursive behavior explicitly. https://github.com/apache/arrow/blob/dbedcfce79f221e9217ec34725668a686c6d4478/cpp/src/arrow/compute/kernels/vector_nested.cc#L108-L113 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
