austin3dickey commented on code in PR #40925:
URL: https://github.com/apache/arrow/pull/40925#discussion_r1558238148
##########
dev/archery/archery/benchmark/google.py:
##########
@@ -57,7 +57,7 @@ def results(self, repetitions=1, repetition_min_time=None):
"--benchmark_out_format=json"]
if repetition_min_time is not None:
- argv.append(f"--benchmark_min_time={repetition_min_time:.6f}")
+ argv.append(f"--benchmark_min_time={repetition_min_time:.6f}s")
Review Comment:
This was to suppress a message I saw in the logs:
```
LOG(0): Value passed to --benchmark_min_time should have a suffix. Eg.,
`30s` for 30-seconds.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
