austin3dickey commented on PR #40925: URL: https://github.com/apache/arrow/pull/40925#issuecomment-2047674244
Requesting review from @pitrou as well. It looks like this change does cause slight regressions in some C++ benchmarks. Here's [an example](https://conbench.ursa.dev/benchmark-results/06615ace7d9d7cb0800055526a223269/). I looked through the graphs, and it looks like in most cases the regressions simply offset the improvement we got from upgrading to the GNU 12.3.0 compiler back on July 11. I think the regressions make sense because we're now building Arrow differently, with different cmake options. This should be fine and is a reflection of the environment setup, not the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
