pitrou commented on issue #38325:
URL: https://github.com/apache/arrow/issues/38325#issuecomment-2046967106
I think we should avoid vague and confusing terms such as `strict`, because
it will bear a different meaning and expectations for each person.
As for `requested_device`, if we think it is needed, then let's just add it
immediately?
As for always taking `**kwargs`, this looks reasonable to me. Also, we can
mandate that `None` be the default value for all optional arguments we add in
the future. This makes checking the `kwargs` for non-default values very easy,
for example:
```python
non_default_kwargs = [name for name, value in kwargs.items() if value is
not None]
if non_default_kwargs:
raise NotImplementedError(f"some nice error message with
{non_default_kwargs}")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
