mapleFU commented on code in PR #41117:
URL: https://github.com/apache/arrow/pull/41117#discussion_r1559315110
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -353,7 +355,10 @@ class CompressedInputStream::Impl {
// Try to feed more data into the decompressed_ buffer.
Status RefillDecompressed(bool* has_data) {
- // First try to read data from the decompressor
+ // First try to read data from the decompressor.
+ // This doesn't use `CompressedBufferAvailable()` because when compressed_
+ // exists and available == 0, it might trigger an empty decompress and set
Review Comment:
After re-reading this part of code I finally understand this. Seems
CompressedInputStream is far complex than I first thought that...
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -353,7 +355,10 @@ class CompressedInputStream::Impl {
// Try to feed more data into the decompressed_ buffer.
Status RefillDecompressed(bool* has_data) {
- // First try to read data from the decompressor
+ // First try to read data from the decompressor.
+ // This doesn't use `CompressedBufferAvailable()` because when compressed_
+ // exists and available == 0, it might trigger an empty decompress and set
Review Comment:
After re-reading this part of code I finally understand this. Seems
CompressedInputStream is far complex than I first thought that... Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
