pitrou commented on code in PR #41117:
URL: https://github.com/apache/arrow/pull/41117#discussion_r1559575348
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -297,10 +297,13 @@ class CompressedInputStream::Impl {
return Status::OK();
}
- // Decompress some data from the compressed_ buffer.
- // Call this function only if the decompressed_ buffer is empty.
+ // Decompress some data from the compressed_ buffer and decompressor_.
+ // Call this function only if the decompressed_ buffer is fully consumed.
Status DecompressData() {
+ // Currently, compressed_buffer_available() could be 0 in DecompressData()
+ // because `decompressor_` might have its own internal buffer.
Review Comment:
```suggestion
// compressed_buffer_available() could be 0 here because there might
// still be some decompressed data left to emit even though the
compressed
// data was entirely consumed (especially if the expansion factor is
large)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
