felipecrv commented on PR #41115: URL: https://github.com/apache/arrow/pull/41115#issuecomment-2048072304
> Is this conceptually different from `internal::HasValidityBitmap`? The definition is the same, but the naming is unclear and ambiguous: `internal::HasValidityBitmap(type)` = `true` iff array instances of this type *might have* bitmap buffers `Array(Data|Span)?::HasValidityBitmap()` = `true` iff this *specific array instance* has a bitmap buffer This reads as if the `array.HasValidityBitmap()` check is redundant: ```cpp static_assert(internal::HasValidityBitmap(ArrayType::type_id)); const uint8_t* validity = array.HasValidityBitmap() ? array.buffers[0].data : NULLPTR; ``` vs ```cpp static_assert(internal::is_validity_defined_by_bitmap(ArrayType::type_id)); const uint8_t* validity = array.HasValidityBitmap() ? array.buffers[0].data : NULLPTR; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
