assignUser commented on code in PR #40925:
URL: https://github.com/apache/arrow/pull/40925#discussion_r1560043595
##########
dev/archery/archery/benchmark/google.py:
##########
@@ -57,7 +57,7 @@ def results(self, repetitions=1, repetition_min_time=None):
"--benchmark_out_format=json"]
if repetition_min_time is not None:
- argv.append(f"--benchmark_min_time={repetition_min_time:.6f}")
+ argv.append(f"--benchmark_min_time={repetition_min_time:.6f}s")
Review Comment:
It seems that the warning was added with the flag itself
https://github.com/google/benchmark/blame/70916cbf71f50b9e1e6f13559e10d6dbb92beb32/src/benchmark_runner.cc#L199
so this isn't an issue after all
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
