andygrove commented on code in PR #255:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/255#discussion_r1560136193
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -400,52 +466,98 @@ class CometSparkSessionExtensions
op.right,
SerializedPlan(None))
case None =>
- op
+ opWithInfo(op, info)
}
case c @ CoalesceExec(numPartitions, child)
if isCometOperatorEnabled(conf, "coalesce")
&& isCometNative(child) =>
- QueryPlanSerde.operator2Proto(c) match {
+ val (newOp, info) = QueryPlanSerde.operator2Proto(c)
+ newOp match {
case Some(nativeOp) =>
val cometOp = CometCoalesceExec(c, numPartitions, child)
CometSinkPlaceHolder(nativeOp, c, cometOp)
case None =>
- c
+ opWithInfo(c, info)
}
case s: TakeOrderedAndProjectExec
if isCometNative(s.child) && isCometOperatorEnabled(conf,
"takeOrderedAndProjectExec")
&& isCometShuffleEnabled(conf) &&
- CometTakeOrderedAndProjectExec.isSupported(s) =>
- QueryPlanSerde.operator2Proto(s) match {
+ CometTakeOrderedAndProjectExec
+ .isSupported(s)
+ ._1 =>
+ // TODO: support offset for Spark 3.4
Review Comment:
Do we need to file an issue to track this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
