parthchandra commented on code in PR #255: URL: https://github.com/apache/arrow-datafusion-comet/pull/255#discussion_r1561822823
########## spark/src/main/scala/org/apache/comet/CometExplainInfo.scala: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.comet Review Comment: Agree. But this won't be the only class needing that change. So perhaps better to wait until then and do one bulk update? ########## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ########## @@ -90,6 +98,32 @@ class CometSparkSessionExtensions scanExec.copy(scan = cometScan), runtimeFilters = scanExec.runtimeFilters) + // unsupported parquet data source V2 + case scanExec: BatchScanExec if scanExec.scan.isInstanceOf[ParquetScan] => + val requiredSchema = scanExec.scan.asInstanceOf[ParquetScan].readDataSchema + val info1 = if (isSchemaSupported(requiredSchema)) { + CometExplainInfo(s"Schema $requiredSchema is not supported") + } else { + CometExplainInfo.none + } Review Comment: Good idea. I may have a cleaner way of doing this thoguh, which would make this unnecessary. Give me a little time since I need to change a lot of places to try out the idea. If that doesn't work, I'll change this to use Scala `Option` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
